Add Travis CI and basic unit tests to this library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2018 13:56
ianfixes
changed the title
ianfixes
force-pushed
the
2018-09-13_arduino_ci
branch
4 times, most recently
from
f068188
to
f0e1afc
Compare
ianfixes
force-pushed
the
2018-09-13_arduino_ci
branch
from
f0e1afc
to
696ead5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of using your library to work out some improvements to my arduino_ci framework:
I'm contributing my edits back to this project. In brief, the only modification is to the directory structure such that the arduino library contains the sketch (which formerly lived in the root directory) as an
examplesproject -- this is for the purposes of test compilation.Aside from that, some rudimentary tests were added as proof of concept unit tests. I can't turn on Travis CI for your repo, but I turned it on for mine and the results are here:
https://travis-ci.org/ianfixes/AcceleratedLED/builds/
This build error due to a segfault is eliminated by the code in this pull request