New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index picking for ad file #10

Closed

1 task done

bgunson opened this issue Feb 23, 2023 · 1 comment

Assignees

Labels

bug enhancement

Milestone

Demo 5: Synchroni...

Owner

bgunson commented Feb 23, 2023 •

edited

Loading

fix index picking in peer/main.js line 29. If length files is 0, then files[Math.floor(Math.random() * files.length)] == files[0] == undefined

The text was updated successfully, but these errors were encountered:

bgunson added the bug label

bgunson assigned ArcaneShift

bgunson added this to the Demo 3: Replication milestone

bgunson added the enhancement label

Owner Author

bgunson commented Feb 23, 2023

If only one peer is connected to proxy, and files.length == 0, then replication will fail from another peer, so:

respond to proxy "give-ad" event with some sort of indicator stating that it failed
maybe, proxy just serves its default ads

bgunson modified the milestones: Demo 3: Replication, Demo 4: Fault Tolerance, Demo 5: Synchronization & Consistency

bgunson linked a pull request

that will close this issue

Closed

bgunson closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment