Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action does not update issue correctly #2

Open
fluxsaas opened this issue Sep 1, 2020 · 5 comments
Open

action does not update issue correctly #2

fluxsaas opened this issue Sep 1, 2020 · 5 comments

Comments

@fluxsaas
Copy link

fluxsaas commented Sep 1, 2020

Hey!

if i followed your instructions from the readme but the issue is update with a blank table:

Bildschirmfoto 2020-09-01 um 14 34 22

etract from Gemfile.lock:

....
RUBY VERSION
   ruby 2.6.3p62

BUNDLED WITH
   2.1.4

rubnning bundle _2.1.4_ outdated --only-explicit --strict locally works fine and returns

.....
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies................

Outdated gems included in the bundle:
  * wkhtmltopdf-heroku (newest 2.12.5.0, installed 2.12.4.0) in group "default"
....
@fluxsaas fluxsaas changed the title action does not update issue correct action does not update issue correctly Sep 1, 2020
@Bhacaz
Copy link
Owner

Bhacaz commented Sep 1, 2020

Hey, thanks for the issue.

I don't thing the problem is in the code, since the Parsing class seems to work with the output you provided.

>> require_relative 'parsing'
true
>> outputs = <<-S
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies................
Outdated gems included in the bundle:
  * wkhtmltopdf-heroku (newest 2.12.5.0, installed 2.12.4.0) in group "default"
S
"Fetching gem metadata from https://rubygems.org/.........\nFetching gem metadata from https://rubygems.org/.\nResolving dependencies................\nOutdated gems included in the bundle:\n  * wkhtmltopdf-heroku (newest 2.12.5.0, installed 2.12.4.0) in group \"default\"\n"
>> parsing = Parsing.new(outputs)
#<Parsing:0x00007ff1f9091738 @output="Fetching gem metadata from https://rubygems.org/.........\nFetching gem metadata from https://rubygems.org/.\nResolving dependencies................\nOutdated gems included in the bundle:\n  * wkhtmltopdf-heroku (newest 2.12.5.0, installed 2.12.4.0) in group \"default\"\n", @data=[{:name=>"wkhtmltopdf-heroku", :newest=>"2.12.5.0", :installed=>"2.12.4.0", :groups=>"default"}]>
>> puts parsing.to_md
![](https://github.com//workflows//badge.svg)

`bundle outdated  --only-explicit --strict`

|Gem|Installed|Newest|Groups|
|---|---|---|---|
|[wkhtmltopdf-heroku](https://rubygems.org/gems/wkhtmltopdf-heroku)|2.12.4.0|2.12.5.0|default|

Can you share your workflow file? There is probably a difference with your local and the Github Action environment.

@fluxsaas
Copy link
Author

fluxsaas commented Sep 1, 2020

pretty much the same as in the readme:

name: 'Outdated Gems'

on: push

jobs:
  outdated_gems:
    runs-on: ubuntu-latest
    name: Outdated gems
    steps:
      - name: Setup Ruby
        uses: ruby/setup-ruby@v1
        with:
          ruby-version: '2.7.0'
      - name: 'Pull outdated gem action script'
        uses: actions/checkout@v2
        with:
          repository: 'Bhacaz/bundler-outdated-action'
      - name: 'Check outdated gems'
        run: 'ruby main.rb'
        env:
          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GEMFILE_REPOSITORY: ${{ github.repository }}

@Bhacaz
Copy link
Owner

Bhacaz commented Sep 1, 2020

Maybe bundler doesn't like the ruby version installed, since your Gemfile.lock specified 2.6.3 and you setup 2.7.0

      - name: Setup Ruby
        uses: ruby/setup-ruby@v1
        with:
-          ruby-version: '2.7.0'
+          ruby-version: '2.6.3'

@fluxsaas fluxsaas closed this as completed Sep 1, 2020
@fluxsaas
Copy link
Author

fluxsaas commented Sep 1, 2020

I think I tried that, I gonna try that again later

@fluxsaas fluxsaas reopened this Sep 1, 2020
@fluxsaas
Copy link
Author

fluxsaas commented Sep 1, 2020

does not seem to work.

Bildschirmfoto 2020-09-01 um 20 48 56

i also checked the existence of the Gemfile and Gemfile.lock with

      - name: 'Check outdated gems'
        run: |
          ruby main.rb
          ls -la

seems OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants