Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect content size and handle correctly #2

Closed
bhaettasch opened this issue Nov 15, 2016 · 4 comments
Closed

Detect content size and handle correctly #2

bhaettasch opened this issue Nov 15, 2016 · 4 comments
Assignees

Comments

@bhaettasch
Copy link
Owner

bhaettasch commented Nov 15, 2016

Currently, the application will not work correctly, it the webserver does not support partial requests.

The loader should istead detect the content size of the returned data and do a single load instead of partial loading if already the whole bunch of data was returned.

This should resolve the problem described in #1

@nxddsnc
Copy link

nxddsnc commented Nov 16, 2016

Do you mean that I should've deleted this part of the code:
// if(partial)
// {
// begin = begin * byteCount;
// end = (end * byteCount)-1;
//
// // Set partial load header
// oReq.setRequestHeader("Range","bytes="+begin+"-"+end)
// }
I've tried, but it made no difference:)

@nxddsnc
Copy link

nxddsnc commented Nov 17, 2016

Hi,
I've walked through the code of encoding. The index reordering part is missing. Maybe that's why.

@bhaettasch bhaettasch changed the title Detect content size and handle correclty Detect content size and handle correctly Nov 18, 2016
bhaettasch added a commit that referenced this issue Nov 18, 2016
Detect when the whole file was returned instead of a partial answer and handle this correctly
@bhaettasch
Copy link
Owner Author

The reordering part is missing since the implementation is not finished yet. Nevertheless, this should not be the reason why the problems occur.

@bhaettasch
Copy link
Owner Author

Implemented in 9fbaf0e.

bhaettasch added a commit that referenced this issue Nov 30, 2016
Detect when the whole file was returned instead of a partial answer and handle this correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants