Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing MainActivity from plugin #22

Closed
wants to merge 2 commits into from

Conversation

fidelisakilan
Copy link

Having MainActivity class within plugin launching app through share causes issue when app have native code added to kotlin class.

Thanks to @HaloWang for pointing out the issue

Related issues:
#9 (comment)
#9 (comment)

@fidelisakilan
Copy link
Author

fidelisakilan commented May 22, 2023

One limitation will be, we have to add intent filter manually in the parent app

            <intent-filter>
                <action android:name="android.intent.action.VIEW" />
                <action android:name="android.intent.action.SEND" />
                <category android:name="android.intent.category.DEFAULT" />
                <data android:mimeType="image/*" />
            </intent-filter>
            <intent-filter>
                <action android:name="android.intent.action.VIEW" />
                <action android:name="android.intent.action.SEND" />
                <category android:name="android.intent.category.DEFAULT" />
                <data android:mimeType="video/*" />
            </intent-filter>

@bhagat-techind
Copy link
Owner

@fidelisakilan Thanks for contributing, I have merged your PR with minor update. So I closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants