forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support max-connection and max-connection-per-IP (apache#10754)
### Motivation Pulsar supports multi-tenant, and there may be one single user occupying all connections. Maybe novice user incorrectly used SDK, or we are being attacked. In order to avoid a single user to affect entire cluster, I think it is important to limit the number of connections. For simplicity, I did not use radix tree to save IPs.
- Loading branch information
Showing
7 changed files
with
293 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137 changes: 137 additions & 0 deletions
137
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConnectionController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.service; | ||
|
|
||
| import java.net.InetSocketAddress; | ||
| import java.net.SocketAddress; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
| import org.apache.commons.lang3.mutable.MutableInt; | ||
| import org.apache.pulsar.broker.ServiceConfiguration; | ||
| import org.apache.pulsar.common.tls.InetAddressUtils; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public interface ConnectionController { | ||
|
|
||
| /** | ||
| * Increase the number of connections counter. | ||
| * @param remoteAddress | ||
| * @return | ||
| */ | ||
| Sate increaseConnection(SocketAddress remoteAddress); | ||
|
|
||
| /** | ||
| * Decrease the number of connections counter. | ||
| * @param remoteAddress | ||
| */ | ||
| void decreaseConnection(SocketAddress remoteAddress); | ||
|
|
||
| enum Sate { | ||
| OK, REACH_MAX_CONNECTION_PER_IP, REACH_MAX_CONNECTION; | ||
| } | ||
|
|
||
|
|
||
| class DefaultConnectionController implements ConnectionController { | ||
| private static final Logger log = LoggerFactory.getLogger(DefaultConnectionController.class); | ||
| private static final Map<String, MutableInt> CONNECTIONS = new HashMap<>(); | ||
| private static final ReentrantLock lock = new ReentrantLock(); | ||
| private static int totalConnectionNum = 0; | ||
|
|
||
| private final int maxConnections; | ||
| private final int maxConnectionPerIp; | ||
| private final boolean maxConnectionsLimitEnabled; | ||
| private final boolean maxConnectionsLimitPerIpEnabled; | ||
|
|
||
| public DefaultConnectionController(ServiceConfiguration configuration) { | ||
| this.maxConnections = configuration.getBrokerMaxConnections(); | ||
| this.maxConnectionPerIp = configuration.getBrokerMaxConnectionsPerIp(); | ||
| this.maxConnectionsLimitEnabled = configuration.getBrokerMaxConnections() > 0; | ||
| this.maxConnectionsLimitPerIpEnabled = configuration.getBrokerMaxConnectionsPerIp() > 0; | ||
| } | ||
|
|
||
| @Override | ||
| public Sate increaseConnection(SocketAddress remoteAddress) { | ||
| if (!maxConnectionsLimitEnabled && !maxConnectionsLimitPerIpEnabled) { | ||
| return Sate.OK; | ||
| } | ||
| if (!(remoteAddress instanceof InetSocketAddress) | ||
| || !isLegalIpAddress(((InetSocketAddress) remoteAddress).getHostString())) { | ||
| return Sate.OK; | ||
| } | ||
| lock.lock(); | ||
| try { | ||
| String ip = ((InetSocketAddress) remoteAddress).getHostString(); | ||
| if (maxConnectionsLimitPerIpEnabled) { | ||
| CONNECTIONS.computeIfAbsent(ip, (x) -> new MutableInt(0)).increment(); | ||
| } | ||
| if (maxConnectionsLimitEnabled) { | ||
| totalConnectionNum++; | ||
| } | ||
| if (maxConnectionsLimitEnabled && totalConnectionNum > maxConnections) { | ||
| log.info("Reject connect request from {}, because reached the maximum number of connections {}", | ||
| remoteAddress, totalConnectionNum); | ||
| return Sate.REACH_MAX_CONNECTION; | ||
| } | ||
| if (maxConnectionsLimitPerIpEnabled && CONNECTIONS.get(ip).getValue() > maxConnectionPerIp) { | ||
| log.info("Reject connect request from {}, because reached the maximum number " | ||
| + "of connections per Ip {}", | ||
| remoteAddress, CONNECTIONS.get(ip).getValue()); | ||
| return Sate.REACH_MAX_CONNECTION_PER_IP; | ||
| } | ||
| } catch (Exception e) { | ||
| log.error("increase connection failed", e); | ||
| } finally { | ||
| lock.unlock(); | ||
| } | ||
| return Sate.OK; | ||
| } | ||
|
|
||
| @Override | ||
| public void decreaseConnection(SocketAddress remoteAddress) { | ||
| if (!maxConnectionsLimitEnabled && !maxConnectionsLimitPerIpEnabled) { | ||
| return; | ||
| } | ||
| if (!(remoteAddress instanceof InetSocketAddress) | ||
| || !isLegalIpAddress(((InetSocketAddress) remoteAddress).getHostString())) { | ||
| return; | ||
| } | ||
| lock.lock(); | ||
| try { | ||
| String ip = ((InetSocketAddress) remoteAddress).getHostString(); | ||
| MutableInt mutableInt = CONNECTIONS.get(ip); | ||
| if (maxConnectionsLimitPerIpEnabled && mutableInt != null && mutableInt.decrementAndGet() <= 0) { | ||
| CONNECTIONS.remove(ip); | ||
| } | ||
| if (maxConnectionsLimitEnabled) { | ||
| totalConnectionNum--; | ||
| } | ||
| } finally { | ||
| lock.unlock(); | ||
| } | ||
| } | ||
|
|
||
| private boolean isLegalIpAddress(String address) { | ||
| return InetAddressUtils.isIPv4Address(address) || InetAddressUtils.isIPv6Address(address); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters