Bunch of messy updates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bhattrajat, so I'm not exactly sure how that error was coming up, but I updated your branch package.json using
pnpm --filter nextjs-app-router use-shopping-cart@nextto install the alpha version. The alpha version has the date-fns package installed.I was able to run the project and I didn't see any errors related to date-fns. I haven't done too much digging to figure out why you got that error, though, because it simply should have not tried to refer to date-fns.
I also took the liberty to do a bunch of messy things in your fork.
Try running the project:
pnpm --filter nextjs-app-router devand tell me if it can run. Also are the images broken when you're looking at the cart items and what not?
Sorry this has been such a mess! I been busy and did so much in a hurry. Hopefully I didn't mess anything up