Added 'is_landlocked' property

[jav7zaid]

Issue #47

#Pull Request description

• Added new property is_landlocked in data.json file **source - wikipedia and world map **
• Added new method getCountriesByLandLock() to fetch the data in index.js
• Added test cases to cover the method in getCountriesSpec.js
• Fixed existing test cases.
• Updated readme.md for the new changes.
• Fixed a typo for getCountriesByFamousFor()

[sthiepaan]

Looks promising! I added few comments/suggestions to improve your code 😉
Thank you @jav7zaid!

[sthiepaan]

@jav7zaid you don't need to answer to every single comment - it spams my e-mail so hard 😅... If you decide that you will apply changes, you can just do them and after you finish/commit mark a comment as resolved 😉

[jav7zaid]

@bhatvikrant and @sthiepaan please check the PR ,i have updated it with review comments.
I have removed the package-lock.json file.
Let me know if looks good to be merged.

[sthiepaan]

@jav7zaid after you finish applying and pushing changes - instead of writing a comment - you can click on little circle icon in Reviewers section (located at top right of the Pull Request) near reviewer nickname 😉

[sthiepaan]

LGTM

[bhatvikrant]

@jav7zaid please resolve conflicts and then its good to go!

[sthiepaan]

I would like to merge this Pull Request but unfortunately we struggle with some merge conflicts. Conflicts are in:

• README.md
• data/data.json
• index.js
• spec/getCountriesSpec.js

@jav7zaid could you resolve them? 😉

[jav7zaid]

I would like to merge this Pull Request but unfortunately we struggle with some merge conflicts. Conflicts are in:

• README.md
• data/data.json
• index.js
• spec/getCountriesSpec.js

@jav7zaid could you resolve them? 😉

done @sthiepaan

[sthiepaan]

LGTM

[jav7zaid]

I would like to merge this Pull Request but unfortunately we struggle with some merge conflicts. Conflicts are in:

• README.md
• data/data.json
• index.js
• spec/getCountriesSpec.js

@jav7zaid could you resolve them? 😉

done @sthiepaan

i think my changes disturbed the existing test cases fixing them.

[sthiepaan]

@jav7zaid actually yes, you broke it! 😅... Always run npm test before making a commit.
Please make a new Pull Request with fix for that ASAP.