Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore usage section intro #60

Closed
wants to merge 1 commit into from
Closed

Restore usage section intro #60

wants to merge 1 commit into from

Conversation

nlssn
Copy link

@nlssn nlssn commented Oct 23, 2020

I noticed this scrambled message on row 37 in README.md: This section contains nt to _contribute_ to open source? Try solving our issues [here](https://github.com/bhatvikrant/world-countries-capitals/issues)\_

It seems that the change comes from cd89366#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R37.

My commit restores the text to what was there previously.

@sthiepaan
Copy link
Collaborator

Nice catch @nlssn but unfortunately it is not necessary anymore because we refactor whole documentation (#58).
Next time, please create an Issue first so you avoid situation where you put some effort before any confirmation that it's needed.

I will close this Pull Request for now.

@sthiepaan sthiepaan closed this Oct 24, 2020
@nlssn
Copy link
Author

nlssn commented Oct 24, 2020

Thanks for the reply @sthiepaan.

Didn't think much of it since this was just a quick edit, but I will definitely make sure to create an issue next time.

@sthiepaan sthiepaan mentioned this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants