Helpful classpath adding ancestor of target directory

[danielcompton]

In development we use Figwheel to build our ClojureScript resources. We serve target/resources/acme/public for our static assets and build to target/resources/acme/public/js/frontend.js. We have target/resources added as a path in our deps.edn file.

I think having acme between resources and public is confusing the helpful classpath handling. When we build, Figwheel looks for target/resources/acme as a directory on the classpath, and doesn't realise that target/resources is on the classpath.

[Figwheel] Validating figwheel-main.edn
[Figwheel] figwheel-main.edn is valid \(ツ)/
[Figwheel:WARNING] Attempting to dynamically add "target/resources/acme" to classpath!
[Figwheel:WARNING] Target directory "target/resources/acme" is not on the classpath
[Figwheel:WARNING] Please fix this by adding "target/resources/acme" to your classpath
 I.E.
 For Clojure CLI Tools in your deps.edn file:
    ensure "target/resources/acme" is in your :paths key

 For Leiningen in your project.clj:
   add it to the :resource-paths key

[Figwheel] Compiling build app to "target/resources/acme/public/js/frontend.js"
[Figwheel] Successfully compiled build app to "target/resources/acme/public/js/frontend.js" in 4.418 seconds.
[Figwheel] Watching paths: ("src/cljs" "src/cljc") to compile build - app
[Figwheel] Starting Server at http://localhost:9500

(fw-util/dir-on-classpath? "target/resources")
=> "<redacted>/acme-app/target/resources"
(fw-util/dir-on-classpath? "target/resources/acme")
=> nil

Here is our config:

{:id "app"
 :options {:main acme.frontend.main
           :preloads [day8.re-frame-10x.preload]
           :parallel-build true
           :output-to "target/resources/acme/public/js/frontend.js"
           :output-dir "target/resources/acme/public/js/frontend.out"
           :optimizations :none}
 :config {:watch-dirs ["src/cljs" "src/cljc"]
          :css-dirs ["target/resources/acme/public/css"]
          ;; We make our resources go to target/resources/acme instead
          ;; of target/resources. Figwheel doesn't understand this and
          ;; tries to add target/resources to the classpath a second time.
          ;; Disabling helpful-classpaths will prevent this, though we still get
          ;; a warning from Figwheel that the directory is not on the classpath.
          :helpful-classpaths false}}

We are turning off :helpful-classpaths, but I think this might actually be a bug? I could be wrong though.

[bhauman]

Yes this looks buggy to me.

Also keep in mind that you can set :target-dir to target/resources/acme and then use the default output-to and output-dir this might make things smoother in the meantime.

[bhauman]

I've looked at this again and I don't think it was a bug.

"target/resources/acme" needs to be on the classpath because Jetty serves the "/public" directory not the "/*/public" directory.

Sorry for not looking at this sooner.