Remove tools.nrepl dependency
#718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make things work with `lein-master`. Seems like the precense of `tools.nrepl` in the deps make the dynamic selection of which nrepl middleware to use fail.
|
If there is there something missing in this PR, please let me know. |
|
What is |
|
sorry for the delay I'm not getting any notifications from gitihub on many of my projects. |
|
This current patch breaks using figwheel-sidecar as a standalone library, which makes this a bigger issue. |
|
@bhauman The current Lein release ships with nREPL 0.5.3, so probably it makes sense to update this dependency indeed. I think it's safer for projects to depend on the new nREPL and fallback to the old one if someone's running on a older leiningen. |
|
I'm changing the nrepl dep to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make things work with
lein master. Seems like the precenseof
tools.nreplin the deps make the dynamic selection of whichnrepl middleware to use fail.
The reformatting was done by
cljfmtin my editor. I left them, since they make sense. Let me know if they shouldn't be part of the PR.