Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Django version check #23

Closed
rglsk opened this issue Jan 31, 2022 · 3 comments
Closed

Improve Django version check #23

rglsk opened this issue Jan 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@rglsk
Copy link
Contributor

rglsk commented Jan 31, 2022

The current check works only for Django 3.xxx:

django.VERSION[0] >= 3 and django.VERSION[1] >= 1:

Recently a new Django version was released 4.0..., with the old check the package is not working because of: django.VERSION[1] >= 1
rglsk pushed a commit to rglsk/django-jsonform that referenced this issue Jan 31, 2022
bhch#23 Improve django version check using pkg_resources
cee78b3
rglsk pushed a commit to rglsk/django-jsonform that referenced this issue Jan 31, 2022
bhch#23 Improve django version check using pkg_resources
e3f4a48
@rglsk
Copy link
Contributor Author

rglsk commented Jan 31, 2022

@bhch May I ask you for review and merge if possible? 💪

@bhch bhch added the bug Something isn't working label Jan 31, 2022
bhch pushed a commit that referenced this issue Jan 31, 2022
@rglsk
#23 Improve django version check using pkg_resources (#24)
3f08230
@bhch
Copy link
Owner

bhch commented Jan 31, 2022

Fixed in #24.

@bhch bhch closed this as completed Jan 31, 2022
@bhch
Copy link
Owner

bhch commented Jan 31, 2022 •
edited
Loading

I've released a new version (v2.7.0). Please upgrade.

Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rglsk @bhch