Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace serde_cbor with ciborium #560

Merged
merged 2 commits into from
Jul 2, 2022
Merged

replace serde_cbor with ciborium #560

merged 2 commits into from
Jul 2, 2022

Conversation

crepererum
Copy link
Contributor

Fixes #534.

@lemmih
Copy link
Collaborator

lemmih commented Feb 28, 2022

Looks good. Could you change the target from master to version-0.4?

@crepererum crepererum changed the base branch from master to version-0.4 February 28, 2022 13:28
@crepererum
Copy link
Contributor Author

Looks good. Could you change the target from master to version-0.4?

done

@crepererum
Copy link
Contributor Author

Mmh, ciborium 0.2 uses Rust edition 2021, which is available as of Rust 1.56. I could try to downgrade to ciborium 0.1 (which uses Rust edition 2018) or we could bump the MSRV for the upcoming 0.4 criterion release. What do you think?

@lemmih
Copy link
Collaborator

lemmih commented Mar 1, 2022

Let's bump the MSRV to 1.56.

@crepererum
Copy link
Contributor Author

@lemmih I've bumped the MSRV, but since this touches the GitHub workflow this change needs your approval to run on CI.

@gtker gtker mentioned this pull request Apr 3, 2022
Closed
@mrnaveira mrnaveira mentioned this pull request Apr 4, 2022
Closed
@jhpratt
Copy link

jhpratt commented May 11, 2022

Any chance this can be merged & released? The diff LGTM and the dependency is causing security advisories due to it being unmaintained.

@poljar poljar mentioned this pull request May 20, 2022
Closed
@MTRNord MTRNord mentioned this pull request May 20, 2022
Closed
@vorot93
Copy link

vorot93 commented Jun 28, 2022

@bheisler @lemmih could this be merged to address downstream security advisories?

@lemmih
Copy link
Collaborator

lemmih commented Jul 2, 2022

Merging. Will work on releasing 0.4

@lemmih lemmih merged commit d4593f4 into bheisler:version-0.4 Jul 2, 2022
@CYBAI CYBAI mentioned this pull request Jul 3, 2022
Closed
@cycraig cycraig mentioned this pull request Jul 28, 2022
Open
@briansmith briansmith mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serde_cbor is unmaintained (RUSTSEC-2021-0127)
4 participants
@crepererum @lemmih @jhpratt @vorot93