Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with PharmacoGx:::.summarizeSensitivityNumbers #81

Open
p-smirnov opened this issue Mar 31, 2021 · 1 comment
Open

What to do with PharmacoGx:::.summarizeSensitivityNumbers #81

p-smirnov opened this issue Mar 31, 2021 · 1 comment

Comments

@p-smirnov
Copy link
Contributor

PharmacoGx:::.summarizeSensitivityNumbers, or equivalently the table returned by sensNumbers is sometimes a slight misrepresentation of the actual data available in Profiles, due to various QC filters which will keep an experiment in the sensitivity info but NA it in the profiles.

Should we even keep this as part of the new PSet object? it will be easy to calculate on the fly, and its also not clear what the intended behaviour should be.

@p-smirnov p-smirnov self-assigned this Mar 31, 2021
@ChristopherEeles
Copy link
Contributor

I like the idea of computing it on the fly. If you think that is the best way to proceed, maybe we can log it as a feature request in https://github.com/bhklab/PharmacoGx/projects/2?

@ChristopherEeles ChristopherEeles added this to Needs triage in Questions & User Support via automation Apr 1, 2021
@ChristopherEeles ChristopherEeles moved this from Needs triage to High priority in Questions & User Support Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants