Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units must be enforced and/or documented #85

Open
bhaibeka opened this issue Apr 1, 2021 · 1 comment
Open

units must be enforced and/or documented #85

bhaibeka opened this issue Apr 1, 2021 · 1 comment

Comments

@bhaibeka
Copy link
Member

bhaibeka commented Apr 1, 2021

We must properly annotate all units in the PSet.

Is it a requirement that all viability measurements be in percentage and all concentrations in uM?

What happens if the user does not respect this? The plot legends will be all wrong and probably other things. How can we enforce it or make it a parameter/slot in the object?

@p-smirnov
Copy link
Contributor

@bhaibeka We have a sanitizeInput function that Mark and I worked on which gives informative errors when things seem wrong. For example, if you set you parameters to computeAUC with viability_as_pct = TRUE but pass in decimals, it notices that there are no values larger than 5 and gives an informative warning.

We can try to enforce certain conventions within PSets, but its hard because some measurements are very bad. Gray has points around 5000% viability (50 as a decimal), for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants