More changes to join api #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bholloway
force-pushed
the
more-changes-to-join-api
branch
from
46d0b19
to
b96aba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR for the custom "join" and related docs. 馃檮
After the previous PR I have absorbed at least one more use case and have amended the API to be a little less crazy.
I previously had this crazy
schemestring that I would have used to signal an API refactor, mostly because I wasn't happy with where the API was. I'm now happy enough to commit to it in the current form. So theschemehas been removed. 馃帀The proof is in the docs here. Primarily this will again be a review of the docs. The tests say that the remainder is working.
Automated tests