Subscription execution

[remorses]

What i changed

• split the Subscribe function in Subscribe (similar to graphql.Do) and ExecuteSubscription (similar to graphql.Execute)
• Subscribe now does the parsing and validation, more similar to graphql.Do
• removed the added context as there was already one in the params
• rewritten tests as a grid
• added testutils for subscriptions tests
• added a SubscriptableSchema that can be used with https://github.com/graph-gophers/graphql-transport-ws

I still have to check if it works ok with the https://github.com/graph-gophers/graphql-transport-ws handler

[bhoriuchi]

While I agree this is useful, there is no reason this needs to be part of the library. It can be implemented outside of the library as all the types it relies on are exported.

[remorses]

Where should this type live? handler package?

[remorses]

i removed it, this will probably live in the handler package as a NewSubscriptionHandler function that uses graphql-transport-ws under the hood

If you want to try some subscirption i made an example here

[bhoriuchi]

i removed it, this will probably live in the handler package as a NewSubscriptionHandler function that uses graphql-transport-ws under the hood

If you want to try some subscirption i made an example here

yes, a different package. Feel free to PR it into the graphql-go-tools if you don't have another place for it. My request there is that it be its own package in a subfolder

[bhoriuchi]

if the resultChannel is closed before this runs, this will panic which is why I had it in this deferred function at the end

[remorses]

the only way the channel can close is the defer close(resultChannel), this means the channel will be closed after ther error handling (defer functions are run from last to first)

I will add a test case for a panic

[bhoriuchi]

looks good