Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions #12

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Add TypeScript definitions #12

merged 2 commits into from
Mar 7, 2021

Conversation

brandongregoryscott
Copy link
Contributor

Resolves #11 Request: TypeScript definitions

  • Add type definitions for async readline functions, add typescript + dtslint dev dependencies for testing definitions
  • Update build scripts to clean and copy additional assets (incl. types) before/after babel runs

Let me know if there's anything that seems off here. I'm not super familiar with the reduce function signature, so that may need tweaking. Didn't want to introduce too much in one PR, but would it make sense to include the dtslint or other example tests in the main test script?

@bhoriuchi bhoriuchi merged commit c5c54ff into bhoriuchi:master Mar 7, 2021
@brandongregoryscott brandongregoryscott deleted the feature/typescript-definitions branch March 7, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: TypeScript definitions
2 participants