Update: Better Rooming #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised Implementation
Better rooming by storing parameterized_name and id
Shutdown on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The flowdock realtime streaming api only sends the flow id, not the flow's parameterized name. If you are going to use Lita in conjunction with the Flowdock Client Gem you'll need the parameterized name in order to do anything.
Redis Keys Used:
flows/parameterized_name => id
flows_id/id => parameterized_name
This being done so that FlowdockSource can make a real room_object. From each room_object you can get:
source.room_object.name = Parameterized Name
source.room_object.id = id