don't reply with empty cc after multiple mentions

Fixes #6
bhouse · Mar 13, 2015 · c03c1c9 · c03c1c9
1 parent d04e1b0
commit c03c1c9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/lita/handlers/group_mention.rb b/lib/lita/handlers/group_mention.rb
@@ -56,10 +56,7 @@ class GroupMention < Handler
       def group_mention(response) # rubocop:disable AbcSize
         return if response.message.body =~ /group\s+mention/
         groups = response.matches.flatten
-
-        groups.each do |g|
-          groups.delete(g) unless redis_groups.keys.include?(g)
-        end
+        groups.reject! { |g| !redis_groups.keys.include?(g) }
         return if groups.empty?
 
         response.reply(t('mention.cc') + union_members(groups))

diff --git a/spec/lita/handlers/group_mention_spec.rb b/spec/lita/handlers/group_mention_spec.rb
@@ -129,4 +129,11 @@
       )
     end
   end
+
+  context 'sending a message with multiple mentions of non-groups' do
+    it "doesn't respond with a cc" do
+      send_message('Hello @user1 @user2')
+      expect(replies.last).not_to match(/^cc/)
+    end
+  end
 end