You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I 100% agree that base64 encoding of SVGs is less ideal than just embedding the escaped SVG XML, it would be convenient if we had a way of using base64, while taking advantage of the 4096 byte limit.
Because of #81 it is not possible to use a single webpack config for SVGs across both CSS and JS. This is inconvenient as it requires our developers to remember to prefix every JS import with jsSvg (which will set noquotes to true). If the SVGs were encoded to base64, noquotes can be set to true across the board, meaning that there would be no extraneous quotes in JS imports, and CSS handles base64 encoded strings that aren't wrapped in quotes. Until the issue in the CSS loader is fixed, this is the ideal solution in our eyes.
The text was updated successfully, but these errors were encountered:
kayneb
pushed a commit
to kayneb/svg-url-loader
that referenced
this issue
Oct 25, 2017
While I 100% agree that base64 encoding of SVGs is less ideal than just embedding the escaped SVG XML, it would be convenient if we had a way of using base64, while taking advantage of the 4096 byte limit.
Because of #81 it is not possible to use a single webpack config for SVGs across both CSS and JS. This is inconvenient as it requires our developers to remember to prefix every JS import with
jsSvg
(which will setnoquotes
totrue
). If the SVGs were encoded to base64,noquotes
can be set totrue
across the board, meaning that there would be no extraneous quotes in JS imports, and CSS handles base64 encoded strings that aren't wrapped in quotes. Until the issue in the CSS loader is fixed, this is the ideal solution in our eyes.The text was updated successfully, but these errors were encountered: