-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: headless functionality in hook #45
base: master
Are you sure you want to change the base?
Conversation
Hello! Well, thanks for the work you put in!
|
tbh it isn't even a breaking change, as whilst this PR uses the hooks syntax of The benefits of going headless are that it decouples the functionality from the presentation, allowing for easier testing, as well as for consuming apps to truly implement the rendering component as desired. |
I'm happy to help contribute on some of those other features / bugs too when I get a spare moment. |
Thanks for the additional context! I'm pretty busy today but I'll answer more thoroughly as soon as I can (incl. on your latest issue, which I find interesting!) |
Hi @jshthornton Sorry it took me so long to respond. You probably moved on to other things since then! After a quick glance at what you did already, it seems good to me! I'm gonna try and write tests for it. |
Has any more work been done on this PR? A hook would be great because I'd then be able to quite easily hook it up to https://www.npmjs.com/package/react-social-login-buttons |
@DiefBell I've been (and still am) super-super-busy and haven't done more than manually testing. I expect to finish a fairly big project in about a month. If you have skills in writing tests, you're more than welcome to contribute! Other options:
Sorry, I really can't devote even the tiniest amount of time to this project right now! |
Hi @jshthornton Sorry for coming back way after due time... I pulled your branch and rebased it on the current master branch. Are you OK with me continuing from there? |
This pull request moves the functionality of the oauth logic into a hook. That way this package can be utilised headlessly allowing developers to manage the UI aspect.
I've put this PR into draft until the following have been done: