Update README.md #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhumijgupta
requested changes
Apr 22, 2020
| @@ -74,7 +74,7 @@ You can directly copy and paste all the commands from the text given here into t | |||
| c_pass VARCHAR(10) NOT NULL, | |||
| Name VARCHAR(20) NOT NULL, | |||
| Address VARCHAR(20) NOT NULL, | |||
| Pincode NUMBER(6) NOT NULL, | |||
| Pincode int NOT NULL, | |||
There was a problem hiding this comment.
A pincode is always of 6 digits, so NUMBER(6) would be a better choice. Open for your opinion.
| @@ -92,7 +92,7 @@ You can directly copy and paste all the commands from the text given here into t | |||
|
|
|||
| CREATE TABLE Seller_Phone_num | |||
| ( | |||
| Phone_num NUMBER(10) NOT NULL, | |||
| Phone_num int NOT NULL, | |||
There was a problem hiding this comment.
A phone number is of 10 digits, NUMBER(10) enforces that constraint. If changed to int, we would also have to add a constraint in schema to make sure that length of Phone_num is 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.