Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Taskcluster config that successfully runs npm run lint #2

Merged
merged 3 commits into from
Dec 13, 2018

Conversation

biancadanforth
Copy link
Owner

v1 References:

v0 References:

This first attempt is a v0 config file based off of [mythmon's v0 .taskcluster.yml](https://github.com/mozilla/normandy/blob/26b6537d7b6a0986f30f58bfb4c0d85ad8a6eea1/.taskcluster.yml).

It needs to be updated to v1 per owlish (Taskcluster engineer).
Lots of QUESTIONS and helpful comments in-line

Right now, I call `npm run lint` instead of `npm test`, just to see if I can get the Docker image from TC to run my own linting scripts successfully.
@biancadanforth biancadanforth force-pushed the taskcluster-config branch 2 times, most recently from b2ad549 to 6cb265f Compare December 13, 2018 18:23
Met with owlish who answered a lot of my initial questions for this first milestone
@biancadanforth biancadanforth changed the title Add Taskcluster config file Initial Taskcluster config that successfully runs npm run lint Dec 13, 2018
@biancadanforth biancadanforth merged commit d4dcc04 into master Dec 13, 2018
@biancadanforth
Copy link
Owner Author

biancadanforth commented Dec 13, 2018

I merged this to verify that my changes to the 'github-push' task work correctly. This task should only run when pushing to the master branch.

Also, since an earlier commit in this PR triggered a TC task on all pushes and a later commit triggered that same TC task only on pushes to master, this PR was also merged to get rid of GitHub's PR state which was still seeking both the PR and push tasks to run and pass. (Note: this did not work in a subsequent PR, but I filed Bug 1514914 to fix it upstream).

BEFORE:

# When a commit is pushed, perform this task
  - $if: 'tasks_for == "github-push"'
    then:
      taskId: {$eval: as_slugid("push_task")}
      # ...

AFTER:

# When a commit is pushed to master, perform this task
# If a branch is merged without being updated first, the tests could pass on the branch
# but not when things are merged into master.
  - $if: 'tasks_for == "github-push"'
    then:
      $if: 'event.ref == "refs/heads/master"'
      then:
        taskId: {$eval: as_slugid("push_task")}
        # ...

@biancadanforth biancadanforth deleted the taskcluster-config branch December 13, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant