Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existance checks for create and drop enums and cascade: true for drop_enum #27

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Existance checks for create and drop enums and cascade: true for drop_enum #27

merged 2 commits into from
Jul 25, 2020

Conversation

hosembafer
Copy link
Contributor

@hosembafer hosembafer commented Jul 25, 2020 •
edited
Loading

#24

What's inside

  • add if_not_exists: true option to create_enum
  • add if_exists: true option to drop_enum
  • add cascade: true to drop_enum

Checklist:

  • I have added tests

@hosembafer
feat: existance checks for create and drop enums
3e1bc80 
Refs bibendi#24
@hosembafer
feat: add cascade option to drop_enum
ac5e7da 
- add cascade option to drop_enum
- remove raise_error warnings by adding specific error

Refs bibendi#24
@hosembafer hosembafer mentioned this pull request Jul 25, 2020
Closed
@hosembafer
Copy link
Contributor Author

Also, would be nice to document if_not_exists, if_exists, cascade or it's enough to rely on Github's hover tooltip annotation?

@bibendi
Copy link
Owner

bibendi commented Jul 25, 2020

Wow! Brilliant!
I don't know what Github's hover tooltip annotation is, but any documentation is always desirable. So, as you wish :)

@hosembafer
Copy link
Contributor Author

hosembafer commented Jul 25, 2020 •
edited
Loading

When hovering on code snippet more than 1-2 sec, tooltip appearing.
I think would be better to issue a new ticket and improve API documentation overall if you think so. Yep, so this PR can be merged regardless of the documentation.

github-tooltip-annotation

@bibendi
Copy link
Owner

bibendi commented Jul 25, 2020

Got it!

@bibendi bibendi merged commit 02062c3 into bibendi:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hosembafer @bibendi