Prevent empty lines in schema.rb if db has no enums #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the contribution! |
|
It seems, we need to drop support for Ruby 2.6 |
Mayurifag
force-pushed
the
prevent-empty-lines-in-schema-rb-without-enums
branch
from
9b17bbe
to
2a8f5c8
Compare
|
I've forcepushed my last commit, — added drop 2.6 ruby due to I've also removed |
bibendi
reviewed
Jan 12, 2024
Mayurifag
force-pushed
the
prevent-empty-lines-in-schema-rb-without-enums
branch
from
d799c98
to
ec2d422
Compare
bibendi
reviewed
Jan 12, 2024
Mayurifag
force-pushed
the
prevent-empty-lines-in-schema-rb-without-enums
branch
from
ec2d422
to
2e0771f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Gem itself is done in context that application has at least one enum.
If someone drops all postgres enum related things via migration and dumps the schema.rb, he will have 2 weird empty lines, which he would not have, if he had no gem.
So I've done this little request, so no empty lines would be added in schema.rb if there are no enums.