Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to override compose command #145

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

d-lebed
Copy link
Contributor

@d-lebed d-lebed commented Mar 18, 2022

Context

Some people who use Mac for development suffer from poor Docker performance on Mac. There is a project called Mutagen that makes Mac devs life much easier. It provides it's own wrapper over docker compose called mutagen-compose

To be able to use Mutagen instead of vanilla Docker compose I would like to add ability to override docker compose command.

Related tickets

What's inside

  • Added ability to specify override for docker command in dip config file.
  • Added ability to override docker command by passing DIP_COMPOSE_COMMAND env variable.

Checklist:

  • I have added tests
  • I have made corresponding changes to the documentation

@bibendi
Copy link
Owner

bibendi commented Mar 18, 2022

Looks very good!
I like this.

BTW, maybe you missed that update https://www.docker.com/blog/speed-boost-achievement-unlocked-on-docker-desktop-4-6-for-mac/ It works very fast on my M1!

@d-lebed
Copy link
Contributor Author

d-lebed commented Mar 18, 2022

Yeah I have not seen that update yet. Will compare it with mutagen later.
I've just fixed specs, so they should not fail now.

@d-lebed d-lebed force-pushed the master branch 2 times, most recently from b4eda5a to cc1dacb Compare March 18, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants