Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed urn association from ids #36

Merged
merged 1 commit into from Aug 8, 2019
Merged

Removed urn association from ids #36

merged 1 commit into from Aug 8, 2019

Conversation

jag3773
Copy link
Collaborator

@jag3773 jag3773 commented Aug 1, 2019

No description provided.

@mvahowe mvahowe self-requested a review August 8, 2019 09:35
@mvahowe
Copy link
Contributor

mvahowe commented Aug 8, 2019

Why do we need the sburrito prefix at all? The longer format made sense for a URN that might be used beyond Scripture Burrito. If that's still the plan, I think URNs still make sense. If that's not the plan, why don't we go back to the original plan which was to prefix system-specific identifiers with the organisation, ie

dbl::whatever
ptx::whatever

It's shorter and easier to read and I really can't see what value "sburrito" adds within a Scripture Burrito document. (I still prefer double colons because, if we no longer have a URN spec, it's possible that some system-specific ids will contain colons than that's the kind of thing that trips up application code, eg someone does

"yabe:123:456".split(":")[1]

they will not get the whole id (and this may be a surprise since, without a URN-type scheme, the don't know which arbitrary organization may turn up in the next document they read.)

@jag3773
Copy link
Collaborator Author

jag3773 commented Aug 8, 2019

The idea discussed in the meeting revolved around "discoverability". However, if someone is looking at a SB metadata document, seems like they would know this is a SB :). I had initially thought an sb prefix would be a clean and concise way to include it in the id system, but I don't have any strong opinions on this one...

@mvahowe
Copy link
Contributor

mvahowe commented Aug 8, 2019

I am merging this with absolutely no coercion whatsoever.

@mvahowe mvahowe merged commit 131287e into master Aug 8, 2019
@mvahowe mvahowe deleted the revert_urn branch August 12, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants