Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search module erases base options #7

Closed
pprw opened this issue Apr 19, 2019 · 3 comments
Closed

Search module erases base options #7

pprw opened this issue Apr 19, 2019 · 3 comments

Comments

@pprw
Copy link

pprw commented Apr 19, 2019

This module prevents the display of an option in site settings (which allows to restrict to templates the advanced search form).

2e5c3eb8bf6bc102d18e2f8f9d69755997407441

If possible Search module options should be added in site settings without replacing this options.
@Daniel-KM
Copy link
Contributor

Is it in my module too (https://github.com/Daniel-KM/Omeka-S-module-Search/)?

@pprw
Copy link
Author

pprw commented May 3, 2019

@Daniel-KM Yes.

Daniel-KM added a commit to Daniel-KM/Omeka-S-module-Search that referenced this issue Jun 24, 2019
@Daniel-KM
Fixed display of site settings (#biblibre/issues/7).
8f28f11
@Daniel-KM
Copy link
Contributor

This is fixed in my module. Not pushed here, as there is more than 100 commits before.

@jajm jajm closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jajm @Daniel-KM @pprw