Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for "BIDS model" #46

Closed
Remi-Gau opened this issue Sep 28, 2020 · 2 comments
Closed

support for "BIDS model" #46

Remi-Gau opened this issue Sep 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Remi-Gau
Copy link
Collaborator

I have started using BIDS model from the BIDS model BEP in the pipeline of our lab because not everyone can use fitlins. :-p

Things are getting to a point where I am thinking to create a function / set of function / class to deal with those (a bit like the analysis module does in pybids).

I think those functionalities would fit better in the bids-matlab repo so I am tempted to work on that here.

My questions are :

  • how do people feel about working on things that are not "vanilla / official" BIDS yet like the BIDS model?

    • pros:
      • those BEP offer some standard which is better than no standard
      • this BEP might not change much
      • if pybids does it, so can we (I like the idea of both packages being more in synch)
    • con :
      • we might have to redo some things and potentially break things downstream if people start using bids-matlab once the BEP become official (I think we need to start having versioned releases).
  • if we agree to support this, how should it be implemented?

    • suggestion : mimicking the pybids implementation maybe? (that I have not looked at yet)
@apjanke
Copy link
Collaborator

apjanke commented Nov 11, 2020

those BEP offer some standard which is better than no standard

And the way to end up with a good standard is to have working "reference implementations" for practitioners to play with while the standard is still being developed, so they can give feedback based on actual use. I think having "preview" BEP functionality available in the library (or maybe in an add-on "bids-matlab-bep" library) would probably be good for the community and the standard.

@Remi-Gau
Copy link
Collaborator Author

Potentially let BIDS matlab help with creating the basic JSON for some simple models.

https://bids-standard.github.io/pybids/analysis/index.html#quickstart

@Remi-Gau Remi-Gau added this to In progress in General Kanban Apr 16, 2021
@Remi-Gau Remi-Gau closed this as completed Mar 1, 2022
General Kanban automation moved this from In progress to Done Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants