Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gulp build as a smoke test #113

Closed
chrisgorgo opened this issue Mar 24, 2016 · 4 comments
Closed

Run gulp build as a smoke test #113

chrisgorgo opened this issue Mar 24, 2016 · 4 comments

Comments

@chrisgorgo
Copy link
Contributor

To improve code quality we should incorporate gulp build (generation of the web version of the validator) as a smoke test (run it even if we are not pushing to gh-pages). This would let us catch errors such as #112 before merging.

@constellates
Copy link
Collaborator

This is done. To test I just pushed a new branch that's a mirror of the current master that's failing during minification.
https://circleci.com/gh/INCF/bids-validator/259

@constellates
Copy link
Collaborator

I also tested rerunning the origin failing build on master and it will not reach the deploy stage now if it can't build. So it won't publish to npm in that case..

@constellates
Copy link
Collaborator

I spoke to soon. There's one more issue I need to address. The build is still pulling the latest version from npm to attempt the build with and not using the current branch being tested.

@constellates
Copy link
Collaborator

Ok I think this is actually finished now. After the initial npm install circle CI now re-installs the validator directly from git and then proceeds with the build.

npm install git+https://git@github.com/incf/bids-validator.git\#${CIRCLE_BRANCH}

I've retested a few builds and everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants