-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run gulp build as a smoke test #113
Comments
This is done. To test I just pushed a new branch that's a mirror of the current master that's failing during minification. |
I also tested rerunning the origin failing build on master and it will not reach the deploy stage now if it can't build. So it won't publish to npm in that case.. |
I spoke to soon. There's one more issue I need to address. The build is still pulling the latest version from npm to attempt the build with and not using the current branch being tested. |
Ok I think this is actually finished now. After the initial npm install circle CI now re-installs the validator directly from git and then proceeds with the build.
I've retested a few builds and everything looks good. |
To improve code quality we should incorporate gulp build (generation of the web version of the validator) as a smoke test (run it even if we are not pushing to gh-pages). This would let us catch errors such as #112 before merging.
The text was updated successfully, but these errors were encountered: