Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to allow empty files #676

Closed
choldgraf opened this issue Dec 30, 2018 · 6 comments · Fixed by #700
Closed

Add a flag to allow empty files #676

choldgraf opened this issue Dec 30, 2018 · 6 comments · Fixed by #700

Comments

@choldgraf
Copy link
Collaborator

A few times now we've run into issues w/ tests because we're running the validator on empty files:

https://travis-ci.org/bids-standard/bids-examples/builds/471063492#L2009

How do folks think about adding a flag to the validator like --allow-empty that would allow empty files to pass the validator, only for use with testing/dev.

@chrisgorgo
Copy link
Contributor

The --ignoreNiftiHeaders flag was originally intended for testing purposes (https://github.com/bids-standard/bids-validator/blob/master/bin/bids-validator#L14). It might be worth replacing it with something more generic such as --ignoreEptyFiles.

Alternatively, you can pass a config file ignoring the 99 error.

@sappelhoff
Copy link
Member

see also #651 and discussion therein

@choldgraf
Copy link
Collaborator Author

I'm equally +1 on:

  1. Giving an --ignoreEmptyFiles flag and using this in the examples
  2. Documenting (in the dev docs) the pattern that @sappelhoff described in the bids-examples PR

@jasmainak
Copy link
Collaborator

+1 also for me!

@chrisgorgo
Copy link
Contributor

Are empty files allowed for some MEG datasets?
https://neurostars.org/t/error-using-bids-validator/3218/9

@sappelhoff
Copy link
Member

@chrisfilo see #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants