New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check ich "ch_names" present in annotations #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
Please:
- add yourself to this file:
Lines 32 to 34 in 1a29f74
- given-names: "Pierre" family-names: "Cutellic" orcid: "https://orcid.org/0000-0002-7224-9222" - add an entry to the changelog, following the syntax you can see in previous entries: https://github.com/bids-standard/pybv/blob/main/docs/changelog.rst
thx. Pls check my comment in the issue, before you merge. So we make sure, I did not introduce some new problems downstream. |
I forgot to mention that you also need to add yourself here: Lines 9 to 27 in 1a29f74
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 625 628 +3
=========================================
+ Hits 625 628 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution @eioe -- may there be many more!
closes #99 .