Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check ich "ch_names" present in annotations #100

Merged
merged 5 commits into from Oct 24, 2022
Merged

Conversation

eioe
Copy link
Contributor

@eioe eioe commented Oct 24, 2022

closes #99 .

@eioe eioe marked this pull request as ready for review October 24, 2022 10:03
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

Please:

  1. add yourself to this file:

    pybv/CITATION.cff

    Lines 32 to 34 in 1a29f74

    - given-names: "Pierre"
    family-names: "Cutellic"
    orcid: "https://orcid.org/0000-0002-7224-9222"
  2. add an entry to the changelog, following the syntax you can see in previous entries: https://github.com/bids-standard/pybv/blob/main/docs/changelog.rst

@eioe
Copy link
Contributor Author

eioe commented Oct 24, 2022

thx. Pls check my comment in the issue, before you merge. So we make sure, I did not introduce some new problems downstream.

@sappelhoff
Copy link
Member

I forgot to mention that you also need to add yourself here:

pybv/docs/changelog.rst

Lines 9 to 27 in 1a29f74

- `Adam Li`_
- `Aniket Pradhan`_
- `Chris Holdgraf`_
- `Clemens Brunner`_
- `Phillip Alday`_
- `Pierre Cutellic`_
- `Richard Höchenberger`_
- `Stefan Appelhoff`_
- `Tristan Stenner`_
.. _Chris Holdgraf: https://bids.berkeley.edu/people/chris-holdgraf
.. _Stefan Appelhoff: http://stefanappelhoff.com/
.. _Tristan Stenner: https://github.com/tstenner
.. _Phillip Alday: https://palday.bitbucket.io/
.. _Clemens Brunner: https://cbrnr.github.io/
.. _Richard Höchenberger: https://hoechenberger.net/
.. _Adam Li: https://adam2392.github.io/
.. _Aniket Pradhan: http://home.iiitd.edu.in/~aniket17133/
.. _Pierre Cutellic: https://github.com/compmonks

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a235be8) compared to base (4af6bba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          625       628    +3     
=========================================
+ Hits           625       628    +3     
Impacted Files Coverage Δ
pybv/_export.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution @eioe -- may there be many more!

@sappelhoff sappelhoff merged commit 98232c5 into bids-standard:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no 'ch_names' in annotations -> Error
2 participants