Add the format parameter to the public API #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
reviewed
May 1, 2019
There was a problem hiding this comment.
+1 on this, but a couple of questions / requests:
- out of interest: why are you interested in saving as int16? Just to save memory space?
- Could you please update the usage example in the README?
- Please add a test for this feature
|
Long story, in short we've got a lot of data in a 24bit binary format (nV resolution) we need to import in Analyzer, but most files only have an absolute voltage range of about 2.5mV so 16bit is more than enough. |
|
Thanks, I'll add a test in my misc PR #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One functionality that's still missing from the public API is the format the data is written as (float32 or int16).
This PR adds the parameter.