FIX+ENH: Fix indexing in events and add measurement date option to writer #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 94.89% 95.37% +0.47%
==========================================
Files 3 3
Lines 196 216 +20
==========================================
+ Hits 186 206 +20
Misses 10 10
Continue to review full report at Codecov.
|
sappelhoff
changed the title
choldgraf
reviewed
Jul 22, 2019
| meas_date : str | None | ||
| The measurement date of the data specified as a string in the format: | ||
| "YYYYMMDDhhmmssuuuuuu". "u" stands for microseconds. If None, defaults | ||
| to '00000000000000000000'. |
There was a problem hiding this comment.
why not allow for ISO 8601 formatting which is a bit more human-readable?
There was a problem hiding this comment.
good point, I am now allowing datetime.datetime objects, I think this should cater to all needs :-)
See: d0467c2
choldgraf
reviewed
Jul 22, 2019
choldgraf
reviewed
Jul 22, 2019
|
Thanks for the review @choldgraf All tests pass, I am merging this now and preparing a new release :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
1
This PR exposes a
meas_dateargument to the writer function and a test suite. The default isNoneand maintains the current behavior.2
This PR fixes #27
I am adding
1to each sample index, to account for BrainVision's 1-based indexing (whereas we expect an array that is 0-based indexed). Note, I changed the docstring forevents. It now mentions that we expect a zero-based indexed array of events.Currently the reasoning that BrainVision uses 1-based indexing is based on inspecting files, and realizing that the "New Segment" marker is always the first one, and always at sample
1... not at0