New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: support for for commas in channel names #53
Conversation
reveals an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good, if you get this one to pass, we should be fine 👍
in that case we do not need to cover comma issues in formatting event type is always Stimulus event description is always numeric so a comma never occurs
this one is blocked until mne-tools/mne-python#8492 is resolved. |
This passes on this mne branch: mne-tools/mne-python#8492 🙂 so once that is merged, we can merge here as well |
merging now to continue development without merge conflicts, and because I am confident in the behavior |
closes #51
commas in (1) event type, and (2) event description are currently irrelevant, because: