Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized the codes and README #36

Closed
wants to merge 3 commits into from
Closed

Conversation

Chapoly1305
Copy link

@Chapoly1305 Chapoly1305 commented Dec 3, 2023

  1. Secure method of private key generation.
    The use of random to generate private key is dangerous. The better practice is to use secure library for generating cryptographic secure random number (key).
  2. Clarify variable names.
    The adv seems to be the public key numbers, and hash is the sha256 then base64 of the public key. Refactored the names improve clarity and matching the concepts (Public Key, Private Key, AdvertisementKey) used in openhaystack.
  3. Add notice for authentication error.
    Catch the password error message instead of crashing.
  4. Add details into README document.
  5. A few formatting improvement suggested by PyCharm.

@Chapoly1305
Copy link
Author

Will create a new pull request.

@Chapoly1305 Chapoly1305 closed this Dec 4, 2023
@biemster
Copy link
Owner

biemster commented Dec 4, 2023

Thanks for this work! I'm not sure I'll merge this, since I have a 100 line target in request_reports.py and in general don't merge unless it fixes a blocking bug. This repo should be taken as minimal proof of concept, please fork if you want to extend functionality / usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants