fix(3524): improve pull query error message

Fixes: confluentinc#3524
big-andy-coates · Oct 11, 2019 · 4cad09c · 4cad09c
1 parent 5315f1e
commit 4cad09c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...src/test/resources/rest-query-validation-tests/materialized-aggregate-static-queries.json b/...src/test/resources/rest-query-validation-tests/materialized-aggregate-static-queries.json
@@ -738,7 +738,7 @@
       ],
       "expectedError": {
         "type": "io.confluent.ksql.rest.entity.KsqlStatementErrorMessage",
-        "message": "Table 'X' is not materialized. KSQL currently only supports static queries on materialized aggregate tables. i.e. those created by a 'CREATE TABLE AS SELECT <fields> FROM <sources> GROUP BY <key>' style statement.",
+        "message": "Table 'X' is not materialized. KSQL currently only supports static queries on materialized aggregate tables. i.e. those created by a 'CREATE TABLE AS SELECT <fields>, <aggregate_functions> FROM <sources> GROUP BY <key>' style statement.",
         "status": 400
       }
     },

diff --git a/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java b/ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
@@ -684,7 +684,8 @@ private static KsqlException notMaterializedException(final SourceName sourceTab
         "Table '" + sourceTable.toString(FormatOptions.noEscape()) + "' is not materialized."
             + " KSQL currently only supports static queries on materialized aggregate tables."
             + " i.e. those created by a"
-            + " 'CREATE TABLE AS SELECT <fields> FROM <sources> GROUP BY <key>' style statement.");
+            + " 'CREATE TABLE AS SELECT <fields>, <aggregate_functions> "
+            + "FROM <sources> GROUP BY <key>' style statement.");
   }
 
   private static KsqlException invalidWhereClauseException(