Add topic names for coherence scores (fix #1016) #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is inappropriate use of
topic_name
field for labeling coherence scores.While
coherence
field ofTopTokensScore
has one number per requested topics,topic_name
field has at mostnum_tokens
numbers per requested topics.We may true to use some parts of
topic_name
filed, e.g. we can try to get eachnum_tokens
-th element, but there are at least two problems:num_tokens
, because tokens with small probability cannot be gathered.Instead of this approach, let's simply add another field into protobuf message
TopTokensScore
which contains topic_names and is aligned with coherence values.