Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hopefully fix deprecation warning #1032

Merged
merged 1 commit into from Nov 9, 2020
Merged

Conversation

bt2901
Copy link
Contributor

@bt2901 bt2901 commented Nov 5, 2020

Apparently, the function used in protobuf code was deprecated:
https://python.readthedocs.io/en/latest/whatsnew/3.6.html#deprecated-functions-and-types-of-the-c-api

which leads to the following warnings (see #975):

DeprecationWarning: PyUnicode_AsEncodedObject() is deprecated; use PyUnicode_AsEncodedString() to encode from str to bytes or PyCodec_Encode() for generic encoding

I think I found the sole line responsible and the fix is really simple, but I'm out of my depth here; could someone please check that everything works and backward-compatible?

@bt2901 bt2901 merged commit 47e37f9 into bigartm:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant