-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
更易读的测试用例;更友好的命名;兼容性更强的方法匹配;增加关键代码注释 #5
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1760587
增强易用性和更容易的测试用例
6b15986
增加框架易用性和测试代码可读性;修改了部分类的名称和增加了注释
c4c7979
增加重入检测
6593f7a
修复测试项目x64情况下找不到文件的问题
6502477
修复测试项目x64下File.ReadAllText找不到文件的问题
b083a40
Set up CI with Azure Pipelines
b8dd58d
Set up CI with Azure Pipelines
90004e5
include readme.md to csproj
2879954
Merge branch 'master' of https://github.com/kissstudio/DotNetDetour
35a3736
include DotNetDetour.nuspec in csproj
a0296ef
Update azure-pipelines.yml for Azure Pipelines
747cef6
update nuget pkg name to kissstudio.DotNetDetour
7978b86
Merge branch 'master' of https://github.com/kissstudio/DotNetDetour
1bf3518
添加编译状态图标
f5d693f
更新readme
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
|
||
namespace DotNetDetour | ||
{ | ||
public interface IMethodMonitor | ||
public interface IMethodHook | ||
{ | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试调试《测试项目》,发现这部分代码并不会生效,多次运行还是照样提示内存已损坏,关掉执行引擎保持运行选项才不会出错。不知道是不是我测试方法错了,如果这个代码确实不会生效,那就移除掉吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我指的是IsDetourInstalled函数
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想了好几遍,对于重入的可能性几乎没有,ClrMethodHook,Install只会运行一次(忽略错误的在超高并发代码中调用),后续InstallInternal调用是AssemblyLoad事件引发的,如果一个程序集被加载,就算是同一个dll,这个程序集是全新的(猜的,有时间我用CSharpCodeProvider动态编译验证一下)。
其实想说的是,如果此代码确实没用,Monitor.cs中engine.Patch那段代码可以少好多,哈哈哈