Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added text-color extension #758

Merged
merged 5 commits into from
May 4, 2023
Merged

Added text-color extension #758

merged 5 commits into from
May 4, 2023

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented May 2, 2023

Description

  • Added: text-color extension

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@AbhayVAshokan _a

@gaagul gaagul requested a review from AbhayVAshokan as a code owner May 2, 2023 18:12
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-758 May 2, 2023 18:12 Inactive
AbhayVAshokan
AbhayVAshokan requested changes May 3, 2023
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaagul _a https://vimeo.com/823242162/b0d1d08605

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned AbhayVAshokan May 3, 2023
@gaagul
Copy link
Contributor Author

gaagul commented May 3, 2023

@gaagul _a https://vimeo.com/823242162/b0d1d08605

I will try to implement the debounce logic if it is possible , or else i will let you know and we can proceed with the same approach we have now.

@unnitallman unnitallman temporarily deployed to neeto-editor-pr-758 May 4, 2023 06:39 Inactive
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-758 May 4, 2023 06:58 Inactive
@gaagul
Copy link
Contributor Author

gaagul commented May 4, 2023 •
edited
Loading

@AbhayVAshokan _a I have improved the color picker with debounce logic as discussed, Please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned gaagul May 4, 2023
AbhayVAshokan
AbhayVAshokan approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaagul _a a small improvement. Please merge after making this change: https://vimeo.com/823680177/fdc2c94145

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned AbhayVAshokan May 4, 2023
@AbhayVAshokan AbhayVAshokan added the patch Releases small requests or bug fixes. label May 4, 2023
@unnitallman unnitallman temporarily deployed to neeto-editor-pr-758 May 4, 2023 14:18 Inactive
@gaagul gaagul merged commit c47f8a6 into main May 4, 2023
@gaagul gaagul deleted the 713-text-color-option branch May 4, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@gaagul gaagul

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploading status bug Add the color extension
3 participants
@gaagul @AbhayVAshokan @unnitallman