Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR add the parameter of charge to SAGE processor and other properties #363

Merged
merged 7 commits into from
Mar 28, 2024
Merged

This PR add the parameter of charge to SAGE processor and other properties #363

merged 7 commits into from
Mar 28, 2024

Conversation

ypriverol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 6a5e319

+| ✅ 279 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-26 06:20:57

@ypriverol ypriverol changed the title This PR add the parameter of charge to SAGE processor. This PR add the parameter of charge to SAGE processor and other properties Mar 26, 2024
@ypriverol ypriverol requested review from daichengxin and jpfeuffer and removed request for jpfeuffer March 26, 2024 11:57
@ypriverol ypriverol merged commit 6269367 into bigbio:dev Mar 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daichengxin daichengxin daichengxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ypriverol @daichengxin