Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if-else branch in column name validation #143

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix if-else branch in column name validation #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdrf_pipelines/sdrf/sdrf_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def validate_column_names(self, panda_sdrf):
m = re.match(self._column_template, cname)
if not m:
errors.append(cname)
if m.group().startswith("factor value"):
elif m.group().startswith("factor value"):
if (
m.group().replace("factor value", "comment") not in panda_sdrf.columns
and m.group().replace("factor value", "characteristics") not in panda_sdrf.columns
Expand Down