LTI-386: Fix error of settings page not showing (#329)

bigbluebutton · Jun 20, 2024 · 8658929 · 8658929
1 parent 4377647
commit 8658929
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/models/room.rb b/app/models/room.rb
@@ -18,7 +18,7 @@
 class Room < ApplicationRecord
   before_save :default_values
 
-  store_accessor :settings, [:lockSettingsDisableCam, :lockSettingsDisableMic, :lockSettingsDisablePrivateChat, :lockSettingsDisablePublicChat, :lockSettingsDisableNote]
+  store_accessor :settings, %i[lockSettingsDisableCam lockSettingsDisableMic lockSettingsDisablePrivateChat lockSettingsDisablePublicChat lockSettingsDisableNote]
   store_accessor :settings, %i[waitForModerator allModerators guestPolicy record autoStartRecording allowStartStopRecording]
 
   # after_find is used for the following so that rooms that already exist will have these fields upon launch
@@ -30,6 +30,7 @@ class Room < ApplicationRecord
   include BrokerHelper
 
   RECORDING_SETTINGS = [:record, :autoStartRecording, :allowStartStopRecording].freeze
+  ROOM_SETTINGS = [:guestPolicy, :allModerators, :waitForModerator].freeze
   CODE_LENGTH = 10
 
   def default_values

diff --git a/app/views/rooms/_form.html.erb b/app/views/rooms/_form.html.erb
@@ -65,8 +65,8 @@
   <%= form.hidden_field :viewer, value: @room.viewer %> 
 
   <% @lockSettings = @room.settings.select { |key, value| key.start_with?("lock")} %>
-  <% @recordingSettings = @room.settings.select { |key, value| !key.start_with?("lock") && Room::RECORDING_SETTINGS.include?(key.to_sym)} %>
-  <% @roomSettings = @room.settings.select { |key, value| !key.start_with?("lock") && !Room::RECORDING_SETTINGS.include?(key.to_sym)} %>
+  <% @recordingSettings = @room.settings.select { |key, value| Room::RECORDING_SETTINGS.include?(key.to_sym)} %>
+  <% @roomSettings = @room.settings.select { |key, value| Room::ROOM_SETTINGS.include?(key.to_sym)} %>
 
   <details>
     <summary class="text-black"><%= t('default.room.settings.lockSettingsTitle') %>