Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 18 Docker #371

Open
maxjacobs283 opened this issue May 6, 2021 · 1 comment
Open

Ubuntu 18 Docker #371

maxjacobs283 opened this issue May 6, 2021 · 1 comment

Comments

@maxjacobs283
Copy link

I have noticed that the script will install docker-ce which is at version 20, however the official repository includes docker.io at version 20 aswell. As such it doesn't make sense to me why the script would rely on an external source.
Also when I tried to install docker.io the script still force installed docker-ce over docker.io. I advice including a check for the already installed docker version or retiring the external repository in favor of the canonical repository to increase upgradability when a BBB for Ubuntu 20 releases.

@paulmenzel
Copy link
Contributor

paulmenzel commented Apr 8, 2024

The same problem exists with the script for BBB 3.0.

Looking at the script, it explicitly looks for docker-ce (ce means community edition).

bbb-install/bbb-install.sh

Lines 1388 to 1395 in 26ce2d1

if ! dpkg -l | grep -q docker-ce; then
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu \
$(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
apt-get update
need_pkg docker-ce docker-ce-cli containerd.io
fi

I also think, that Ubuntu’s packages should be used. Version 24.0.5 is even in the suite jammy-updates, if 20.10.21 should be too old.

jammy (22.04LTS) (admin): Linux container runtime [universe]
• 20.10.21-0ubuntu1~22.04.3 [security]: amd64
• 20.10.12-0ubuntu4 [ports]: arm64 armhf ppc64el riscv64 s390x
jammy-updates (admin): Linux container runtime [universe]
• 24.0.5-0ubuntu1~22.04.1: amd64 arm64 armhf ppc64el riscv64 s390x

paulmenzel added a commit to paulmenzel/bbb-install that referenced this issue Apr 10, 2024
Some threat models consider external non-distribution archives bad. As
the distribution package archives are already trusted for the
installation of the whole system, and they contain Docker and
docker-compose, use those despite their older version.

Jammy contains versions

Resolves: bigbluebutton#371
paulmenzel added a commit to paulmenzel/bbb-install that referenced this issue May 22, 2024
Some threat models consider external non-distribution archives bad. As
the distribution package archives are already trusted for the
installation of the whole system, and they contain Docker and
docker-compose, use those despite their older version.

Jammy contains versions

Resolves: bigbluebutton#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants