Better XML to core objects conversion.

bigbluebutton · Jan 20, 2016 · 2480bed · 2480bed
1 parent 80408a0
commit 2480bed
Show file tree

Hide file tree

Showing 10 changed files with 193 additions and 208 deletions.
diff --git a/.php_cs b/.php_cs
@@ -17,8 +17,8 @@ return Symfony\CS\Config\Config::create()
         'multiple_use', 'parenthesis', 'php_closing_tag', 'trailing_spaces', 'visibility', 'array_element_no_space_before_comma',
         'array_element_white_space_after_comma', 'blankline_after_open_tag', 'duplicate_semicolon', 'extra_empty_lines',
         'function_typehint_space', 'include', 'list_commas ', 'namespace_no_leading_whitespace', 'no_blank_lines_after_class_opening ',
-        'no_empty_lines_after_phpdocs ', 'object_operator', 'operators_spaces', 'phpdoc_indent', 'phpdoc_params', 'return',
-        'self_accessor', 'single_array_no_trailing_comma', 'single_quote', 'spaces_cast', 'standardize_not_equal',
+        'no_empty_lines_after_phpdocs ', 'object_operator', 'operators_spaces', 'phpdoc_indent', 'phpdoc_params',
+        'return', 'self_accessor', 'single_array_no_trailing_comma', 'single_quote', 'spaces_cast', 'standardize_not_equal',
         'ternary_spaces', 'unneeded_control_parentheses', 'unused_use', 'whitespacy_lines', 'short_array_syntax',
         'align_double_arrow', 'align_equals'
     ))

diff --git a/src/Core/Attendee.php b/src/Core/Attendee.php
@@ -36,22 +36,22 @@ class Attendee
     private $role;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $isPresenter;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $isListeningOnly;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $hasJoinedVoice;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $hasVideo;
 
@@ -95,31 +95,31 @@ public function getRole()
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
     public function isIsPresenter()
     {
         return $this->isPresenter;
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
     public function isIsListeningOnly()
     {
         return $this->isListeningOnly;
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
     public function isHasJoinedVoice()
     {
         return $this->hasJoinedVoice;
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
     public function isHasVideo()
     {

diff --git a/src/Core/Meeting.php b/src/Core/Meeting.php
@@ -37,7 +37,7 @@ class Meeting
     private $meetingName;
 
     /**
-     * @var integer
+     * @var int
      */
     private $creationTime;
 
@@ -47,7 +47,7 @@ class Meeting
     private $creationDate;
 
     /**
-     * @var integer
+     * @var int
      */
     private $voiceBridge;
 
@@ -67,42 +67,42 @@ class Meeting
     private $moderatorPassword;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $hasBeenForciblyEnded;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $isRunning;
 
     /**
-     * @var integer
+     * @var int
      */
     private $participantCount;
 
     /**
-     * @var integer
+     * @var int
      */
     private $listenerCount;
 
     /**
-     * @var integer
+     * @var int
      */
     private $voiceParticipantCount;
 
     /**
-     * @var integer
+     * @var int
      */
     private $videoCount;
 
     /**
-     * @var integer
+     * @var int
      */
     private $duration;
 
     /**
-     * @var boolean
+     * @var bool
      */
     private $hasUserJoined;
 
@@ -114,7 +114,7 @@ public function __construct($xml)
     {
         $this->meetingId             = $xml->meetingID->__toString();
         $this->meetingName           = $xml->meetingName->__toString();
-        $this->creationTime          = intval($xml->createTime);
+        $this->creationTime          = doubleval($xml->createTime);
         $this->creationDate          = $xml->createDate->__toString();
         $this->voiceBridge           = intval($xml->voiceBridge);
         $this->dialNumber            = $xml->dialNumber->__toString();
@@ -147,7 +147,7 @@ public function getMeetingName()
     }
 
     /**
-     * @return int
+     * @return double
      */
     public function getCreationTime()
     {
@@ -195,17 +195,17 @@ public function getModeratorPassword()
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
-    public function isHasBeenForciblyEnded()
+    public function hasBeenForciblyEnded()
     {
         return $this->hasBeenForciblyEnded;
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
-    public function isIsRunning()
+    public function isRunning()
     {
         return $this->isRunning;
     }
@@ -251,9 +251,9 @@ public function getDuration()
     }
 
     /**
-     * @return boolean
+     * @return bool
      */
-    public function isHasUserJoined()
+    public function hasUserJoined()
     {
         return $this->hasUserJoined;
     }