Merge pull request #19750 from GuiLeme/fix-external-video-get-volume

Fix: Fix getVolume is not a function
bigbluebutton · Mar 6, 2024 · 16a4690 · 16a4690
2 parents 58a0efe + d79eacf
commit 16a4690
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/...5/imports/ui/components/external-video-player/external-video-player-graphql/component.tsx b/...5/imports/ui/components/external-video-player/external-video-player-graphql/component.tsx
@@ -251,22 +251,24 @@ const ExternalVideoPlayer: React.FC<ExternalVideoPlayerProps> = ({
   }, [playerRef.current]);
 
   // --- Plugin related code ---;
-  if (playerRef.current?.getInternalPlayer() && playerRef.current?.getInternalPlayer()?.isMuted
-    && typeof playerRef.current?.getInternalPlayer()?.isMuted === 'function'
-    && playerRef.current?.getInternalPlayer()?.isMuted() !== isMuted.current) {
-    isMuted.current = playerRef.current?.getInternalPlayer()?.isMuted();
+  const internalPlayer = playerRef.current?.getInternalPlayer ? playerRef.current?.getInternalPlayer() : null;
+  if (internalPlayer && internalPlayer?.isMuted
+    && typeof internalPlayer?.isMuted === 'function'
+    && internalPlayer?.isMuted() !== isMuted.current) {
+    isMuted.current = internalPlayer?.isMuted();
     window.dispatchEvent(new CustomEvent(ExternalVideoVolumeUiDataNames.IS_VOLUME_MUTED, {
       detail: {
-        value: playerRef.current?.getInternalPlayer()?.isMuted(),
+        value: internalPlayer?.isMuted(),
       } as ExternalVideoVolumeUiDataPayloads[ExternalVideoVolumeUiDataNames.IS_VOLUME_MUTED],
     }));
   }
-  if (playerRef.current?.getInternalPlayer()?.getVolume()
-    && playerRef.current?.getInternalPlayer()?.getVolume() !== currentVolume.current) {
-    currentVolume.current = playerRef.current?.getInternalPlayer()?.getVolume();
+  if (internalPlayer && internalPlayer?.getVolume
+    && typeof internalPlayer?.getVolume === 'function'
+    && internalPlayer?.getVolume() !== currentVolume.current) {
+    currentVolume.current = internalPlayer?.getVolume();
     window.dispatchEvent(new CustomEvent(ExternalVideoVolumeUiDataNames.CURRENT_VOLUME_VALUE, {
       detail: {
-        value: playerRef.current?.getInternalPlayer()?.getVolume() / 100,
+        value: internalPlayer?.getVolume() / 100,
       } as ExternalVideoVolumeUiDataPayloads[ExternalVideoVolumeUiDataNames.CURRENT_VOLUME_VALUE],
     }));
   }