Merge pull request #19532 from gabriellpr/fix-flaky-tests

test: Update screenshots options test
bigbluebutton · Feb 5, 2024 · 5abe7e5 · 5abe7e5
2 parents 3e72e2d + 25bee83
commit 5abe7e5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/bigbluebutton-tests/playwright/core/elements.js b/bigbluebutton-tests/playwright/core/elements.js
@@ -468,7 +468,7 @@ exports.wbStickyNoteShape = 'button[data-testid="tools.note"]';
 exports.wbTextShape = 'button[data-testid="tools.text"]';
 exports.wbTypedText = 'div[data-shape="text"]';
 exports.wbTypedStickyNote = 'div[data-shape="sticky"]';
-exports.wbDrawnRectangle = 'div[data-shape="rectangle"]';
+exports.wbDrawnRectangle = 'div[data-shape-type="geo"]';
 exports.wbDrawnLine = 'div[data-shape="draw"]';
 exports.multiUsersWhiteboardOn = 'button[data-test="turnMultiUsersWhiteboardOn"]';
 exports.multiUsersWhiteboardOff = 'button[data-test="turnMultiUsersWhiteboardOff"]';

diff --git a/bigbluebutton-tests/playwright/options/options.js b/bigbluebutton-tests/playwright/options/options.js
@@ -65,12 +65,12 @@ class Options extends MultiUsers {
     await this.modPage.waitAndClick(e.modalConfirmButton);
 
     const modPageLocator = this.modPage.getLocator('body');
+    await this.modPage.page.setViewportSize({ width: 1924, height: 1080 });
     const screenshotOptions = {
       maxDiffPixels: 1000,
     };
 
     await this.modPage.closeAllToastNotifications();
-
     await expect(modPageLocator).toHaveScreenshot('moderator-page-dark-mode.png', screenshotOptions);
 
     await openSettings(this.modPage);
@@ -85,6 +85,8 @@ class Options extends MultiUsers {
     await this.modPage.waitAndClick(e.modalConfirmButton);
 
     const modPageLocator = this.modPage.getLocator('body');
+
+    await this.modPage.page.setViewportSize({ width: 1924, height: 1080 });
     const screenshotOptions = {
       maxDiffPixels: 1000,
     };

diff --git a/...t/options/options.spec.js-snapshots/moderator-page-dark-mode-Chromium-linux.png b/...t/options/options.spec.js-snapshots/moderator-page-dark-mode-Chromium-linux.png
diff --git a/...t/options/options.spec.js-snapshots/moderator-page-font-size-Chromium-linux.png b/...t/options/options.spec.js-snapshots/moderator-page-font-size-Chromium-linux.png
diff --git a/bigbluebutton-tests/playwright/presentation/presentation.spec.js b/bigbluebutton-tests/playwright/presentation/presentation.spec.js
@@ -7,7 +7,7 @@ const customStyleAvoidUploadingNotifications = encodeCustomParams(`userdata-bbb_
 
 test.describe.parallel('Presentation', () => {
   // https://docs.bigbluebutton.org/2.6/release-tests.html#navigation-automated
-  test('Skip slide @ci @flaky', async ({ browser, context, page }) => {
+  test('Skip slide @ci', async ({ browser, context, page }) => {
     const presentation = new Presentation(browser, context);
     await presentation.initPages(page);
     await presentation.skipSlide();