Merge pull request #19530 from bigbluebutton/revert-19523-middleware-…

…stop-retransmitting-mutations Revert "Prevent graphql-middlware from re-transmitting Mutations"
bigbluebutton · Jan 26, 2024 · a288d84 · a288d84
2 parents 94a2f77 + 3be1f84
commit a288d84
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/bbb-graphql-middleware/internal/hascli/conn/writer/writer.go b/bbb-graphql-middleware/internal/hascli/conn/writer/writer.go
@@ -96,23 +96,20 @@ RangeLoop:
 						jsonPatchSupported = true
 					}
 
-					//Not storing Mutations because they will not be retransmitted in case of reconnection
-					if messageType != common.Mutation {
-						browserConnection.ActiveSubscriptionsMutex.Lock()
-						browserConnection.ActiveSubscriptions[queryId] = common.GraphQlSubscription{
-							Id:                        queryId,
-							Message:                   fromBrowserMessageAsMap,
-							OperationName:             operationName,
-							StreamCursorField:         streamCursorField,
-							StreamCursorVariableName:  streamCursorVariableName,
-							StreamCursorCurrValue:     streamCursorInitialValue,
-							LastSeenOnHasuraConnetion: hc.Id,
-							JsonPatchSupported:        jsonPatchSupported,
-							Type:                      messageType,
-						}
-						// log.Tracef("Current queries: %v", browserConnection.ActiveSubscriptions)
-						browserConnection.ActiveSubscriptionsMutex.Unlock()
+					browserConnection.ActiveSubscriptionsMutex.Lock()
+					browserConnection.ActiveSubscriptions[queryId] = common.GraphQlSubscription{
+						Id:                        queryId,
+						Message:                   fromBrowserMessageAsMap,
+						OperationName:             operationName,
+						StreamCursorField:         streamCursorField,
+						StreamCursorVariableName:  streamCursorVariableName,
+						StreamCursorCurrValue:     streamCursorInitialValue,
+						LastSeenOnHasuraConnetion: hc.Id,
+						JsonPatchSupported:        jsonPatchSupported,
+						Type:                      messageType,
 					}
+					// log.Tracef("Current queries: %v", browserConnection.ActiveSubscriptions)
+					browserConnection.ActiveSubscriptionsMutex.Unlock()
 				}
 
 				if fromBrowserMessageAsMap["type"] == "stop" {